Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

barrier: 2.1.1 -> 2.2.0 #65293

Merged
merged 1 commit into from Jul 23, 2019
Merged

barrier: 2.1.1 -> 2.2.0 #65293

merged 1 commit into from Jul 23, 2019

Conversation

ar1a
Copy link
Contributor

@ar1a ar1a commented Jul 23, 2019 •
edited

Motivation for this change

New update, and also it won't launch ( see #65292 )

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) (906.4M -> 930.0M)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review FTW 🎊

pkgs/applications/misc/barrier/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/barrier/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/barrier/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/barrier/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/barrier/default.nix Outdated Show resolved Hide resolved
worldofpeace
worldofpeace approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and executed successfully ✔️

I trust you've tested that it works for your purposes.

@ar1a
Copy link
Contributor Author

ar1a commented Jul 23, 2019

yep, good to squash?

@worldofpeace
Copy link
Contributor

yep 👍

@ar1a
Copy link
Contributor Author

ar1a commented Jul 23, 2019

all done

@worldofpeace worldofpeace merged commit f99063f into NixOS:master Jul 23, 2019
@ar1a ar1a deleted the barrier branch July 26, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ar1a @worldofpeace