Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.simple-salesforce: init at 0.74.3 #65346

Merged
merged 1 commit into from Jul 27, 2019
Merged

pythonPackages.simple-salesforce: init at 0.74.3 #65346

merged 1 commit into from Jul 27, 2019

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Jul 24, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [ X Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner July 24, 2019 18:49
@costrouc
Copy link
Member Author

@GrahamcOfBorg build python2Packages.simple-salesforce python3Packages.simple-salesforce

@costrouc
Copy link
Member Author

costrouc commented Jul 24, 2019 •
edited

This is a simplePR that I have tested. LGTM and merge

jonringer
jonringer approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

@costrouc
Copy link
Member Author

Ready for merge

@FRidh FRidh merged commit 4c85595 into NixOS:master Jul 27, 2019
@mmahut mmahut mentioned this pull request Aug 12, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@costrouc @jonringer @FRidh