nixos/zfs: add trim service #65331
Merged
nixos/zfs: add trim service #65331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuskowa
reviewed
Jul 24, 2019
|
markuskowa
reviewed
Jul 25, 2019
| @@ -535,5 +546,20 @@ in | |||
| }; | |||
| }; | |||
| }) | |||
|
|
|||
| (mkIf cfgTrim.enable { | |||
| systemd.timers.zpool-trim = { | |||
There was a problem hiding this comment.
Isn't it short to just add startAt to the service itself? The timer then gets created automatically.
Introduces a trim timer similar to the fstrim service. According to zpool(8) for consumer hardware periodic manual TRIM is preferred over automatic TRIM that ZFS implements. The period of one week is based on recommendations of fstrim.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a trim timer similar to the fstrim service.
According to zpool(8) for consumer hardware periodic manual TRIM
is preferred over automatic TRIM that ZFS implements.
The period of one week is based on recommendations of fstrim.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)