Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plex-media-player: fix startup using wrapQtAppsHook #65353

Merged
merged 1 commit into from Jul 27, 2019
Merged

plex-media-player: fix startup using wrapQtAppsHook #65353

merged 1 commit into from Jul 27, 2019

Conversation

averelld
Copy link
Contributor

Motivation for this change

Fixes startup.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bjornfor
Copy link
Contributor

AFAIK, it's preferred to use qt5.mkDerivation instead of stdenv.mkDerivation to fix this. By doing that the explicit wrapQtAppsHook should not be needed. (I just learned it from here: #65366 (comment))

@worldofpeace
Copy link
Contributor

worldofpeace commented Jul 27, 2019 •
edited

#65399 ref

@worldofpeace worldofpeace merged commit 2a6df2d into NixOS:master Jul 27, 2019
@averelld averelld deleted the pmp-startup-fix branch July 27, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@averelld @bjornfor @worldofpeace