moto: fix colliding dependencies #65316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: python
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
labels
|
This is now working with Python3 λ nix-shell --show-trace -E '(with import ./. {}; (python3.withPackages(ps: [ ps.moto ])).env)' --run 'python -c "import moto; print(moto)"'
<module 'moto' from '/nix/store/y2kcp67fhlv0nk9gqxp799qqjmdrfhmf-python3-3.7.4-env/lib/python3.7/site-packages/moto/__init__.py'>It's still broken for Python2 λ nix-shell --show-trace -E '(with import ./. {}; (python2.withPackages(ps: [ ps.moto ])).env)' --run 'python -c "import moto; print(moto)"'
these derivations will be built:
/nix/store/cg7h5v4sbk88vqrf6lxi3zyf1qivngg7-python-2.7.16-env.drv
building '/nix/store/cg7h5v4sbk88vqrf6lxi3zyf1qivngg7-python-2.7.16-env.drv'...
collision between `/nix/store/0gjgi8l71ygbsp4gjxcnkr3bn4hlmq5k-python2.7-backports.ssl_match_hostname-3.7.0.1/lib/python2.7/site-packages/backports/__init__.py' and `/nix/store/4r37bkp7ply9vvggpxs3lspfa91djk3y-python2.7-backports.tempfile-1.0/lib/python2.7/site-packages/backports/__init__.py'
builder for '/nix/store/cg7h5v4sbk88vqrf6lxi3zyf1qivngg7-python-2.7.16-env.drv' failed with exit code 25
error: build of '/nix/store/cg7h5v4sbk88vqrf6lxi3zyf1qivngg7-python-2.7.16-env.drv' failed |
|
Please rebase. I merged #65318. |
pythonPackages.jsonpatch also creates bin/jsondiff, and packages depending on both are not usable.
kalbasit
force-pushed
the
nixpkgs_fix-moto-collision
branch
2 times, most recently
from
253a517
to
d99c6cc
Compare
|
@GrahamcOfBorg build python3Packages.jsondiff python3Packages.moto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update jsondiff, and remove the jsondiff binary to prevent collision with jsonpatch effectively breaking the moto package.
closes #65287
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)TODO:
__pycache__/__init__.cpython-37.pyccollision betweenpython3.7-backports.weakref-1.0.post1andpython3.7-backports.tempfile-1.0.