Composite color values on the worklet thread #18013
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to:
https://chromium-review.googlesource.com/c/chromium/src/+/1614120
(Allows number values to be composited on the worklet thread)
--and--
https://chromium-review.googlesource.com/c/chromium/src/+/1698667
(Allows creation of keyframe model for color values on compositor)
This CL adds similar functionality as that used for number types to update
color values on the compositor. New classes CrossThreadColorValue and
CSSUnsupportedColorValue were created for CSSPaintValue::GetImage to identify
color valued custom properties as compositable.
Bug: 883721
Change-Id: Ib8c26e5c6c6077b21288de3156fa35cc6e02435d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713747
Commit-Queue: Adam Raine <asraine@google.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687702}