Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.joblib: fix the build on Darwin #65288

Merged
merged 1 commit into from Jul 24, 2019
Merged

pythonPackages.joblib: fix the build on Darwin #65288

merged 1 commit into from Jul 24, 2019

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Jul 23, 2019 •
edited

Motivation for this change

The build for python{2,3}Packages.joblib is broken on master due to a failing test. This commits disables the failing test on Darwin only.

closes #65286

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit
pythonPackages.joblib: fix the build on Darwin
c11606d 
The test test_dispatch_multiprocessing is failing on Darwin; Disabling
it fixes the build.
@kalbasit kalbasit requested a review from FRidh as a code owner July 23, 2019 05:07
@Mic92
Copy link
Member

Mic92 commented Jul 23, 2019

@GrahamcOfBorg build python37Packages.joblib

@kalbasit kalbasit merged commit 4ec8eda into NixOS:master Jul 24, 2019
@kalbasit kalbasit deleted the nixpkgs_fix-python-joblib-darwin branch July 24, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python3Packages.joblib fails on Darwin
2 participants
@kalbasit @Mic92