Couchdb: Don't chown /var/log to couchdb #65347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The default for
logFile
is/var/log/couchdb.log
, and the tmpfile rules chown${dirOf cfg.logFile}
, which is just/var/log
, tocouchdb:couchdb
.This was found by Edes' report on IRC, which looked like
While this bug has been present since the initial couchdb module in
62438c0 by @garbas, this wasn't a
problem, because the initial module only created and chowned
/var/log
if it didn't exist yet, which can't occur because this gets created in
the initial phases of NixOS startup.
However with the recent move from manual preStart chown scripts to
systemd.tmpfiles.rules in 062efe0 (#59389),
this chown is suddenly running unconditionally at every system
activation, therefore triggering the above error.
So I'm glad @aanderse pushed for this, otherwise we wouldn't have found this bug :)
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)