mpd-mpris: init at 0.2.3 #65340
mpd-mpris: init at 0.2.3 #65340
Conversation
| substituteInPlace mpd-mpris.service \ | ||
| --replace /usr/bin $out/bin | ||
| mkdir -p $out/lib/systemd/user | ||
| cp mpd-mpris.service $out/lib/systemd/user |
There was a problem hiding this comment.
Shouldn't this be a NixOS module instead? cc @samueldr @cleverca22 @infinisil.
There was a problem hiding this comment.
Nah this is fine, NixOS supports service files in packages with systemd.packages
There was a problem hiding this comment.
@infinisil could you explain why I'm not able to enable the systemd service with systemctl enable when the package is installed to my user environment? I've wrote about it in my first comment.
There was a problem hiding this comment.
Ah, it's a user service, missed that. I don't think I've ever seen those being used as you described with nix-env, so maybe nobody ever thought of making that work.
It also doesn't seem like home-manager supports running service files from packages, but that's definitely a place where you could add support for that without much trouble.
There was a problem hiding this comment.
So you are saying in general that systemd's user services search path just doesn't include ~/.nix-profile/lib/systemd/user/? That's rather unfortunate.. In any case, I guess it would be find to leave it as ease, unless you wish to add a user module service like services.keybase for example..
There was a problem hiding this comment.
I haven't researched a lot, it might end up being pretty easy to add that to systemd's paths
There was a problem hiding this comment.
TIL after reading this that if I ln -s ~/.nix-profile/lib/systemd ~/.local/share/systemd, systemctl enable works.. However, trying out the following:
export SYSTEMD_UNIT_PATH="$HOME/.nix-profile/lib/systemd/user:"
systemctl --user enable mpd-mpris
Without the symlink, didn't work..
doronbehar
force-pushed
the
package-mpd-mpris
branch
from
497c13f
to
76de731
Compare
|
@GrahamcOfBorg build mpd-mpris |
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)One thing I'm not sure of:
I've add a
postInstallscript that copies the upstream provided user systemd service to the appropriate location in$out. I've installed the package and the service file appears in~/.nix-profile/lib/systemd/useralong with all other user installed packages' user systemd services. However,systemctl --user enable mpd-mpris.servicefails with:Maybe that's not such a big deal as one can manually link
~/.nix-profile/lib/systemd/user/mpd-mpris.serviceto~/.config/systemd/user/default.target.wants/but I'm pretty sure that's something other packages have handled somehow.I couldn't find any mention of something to be done in such a case in the manual..