Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wine-{unstable,staging}: 4.9 -> 4.12.1 #65368

Merged
merged 2 commits into from Jul 28, 2019
Merged

wine-{unstable,staging}: 4.9 -> 4.12.1 #65368

merged 2 commits into from Jul 28, 2019

Conversation

ikervagyok
Copy link
Contributor

Motivation for this change

simple update

Things done

steam runs, successfully tested some games e.g.: Borderlands

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jirkadanek
Copy link
Member

I'm going to try building the closure, and notify maintainers

CC @avnik @7c6f434c @bendlas

jirkadanek
jirkadanek reviewed Jul 27, 2019
View reviewed changes
Copy link
Member

@jirkadanek jirkadanek left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On NixOS x86_64

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on ARCHITECTURE
  • executables tested on ARCHITECTURE
  • all depending packages build
Comments

  • Run only the wine/wine64 binary in wine packages, with http://bulanci.cz/ singleplayer mode (there was running joke about trying to get the game work on Wine around 2010 ;)

  • Only wineWowPackages (and variants) produced wine64 binary, others only 32 bit wine.

  • On first launch wine (and also winetricks, which I presume is wrapper around wine) prompted me to download and install wine-mono, when I did that, it did run a c# hello world for me. WineWowPackages did not ask me to download mono and were able to run hello world straight away, even wineWowPackages.minimal.

    • Is this expected? I thought wine-mono is built into wine.

  • Winetricks asked for update: You are running winetricks-20190310, latest upstream is winetricks-20190615!

  • On my machine, icons in lutra are somehow broken, I figure the maximize, minimize, close window icons should look differently, and the buttons on the right side of the window are laid out weirdly?

lutris

  • Haven't expected that it will take whole day to compile this ;P

@7c6f434c 7c6f434c merged commit 11ed5eb into NixOS:master Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirkadanek jirkadanek jirkadanek left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ikervagyok @jirkadanek @7c6f434c