pulseview,pavucontrol-qt: use qt5.mkDerivation #65366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(@ttuegel) |
bjornfor
requested changes
Jul 25, 2019
ttuegel
reviewed
Jul 25, 2019
This was referenced Jul 25, 2019
|
@ttuegel Would it be possible to open a tracking issue so people to explain to people how then can easily migrate to the qt wrappers? The influx of PRs like this is going to be large, so it would be easy to track if each one opened would reference that single issue also. |
The apps currently do not start because of a missing QT_PLUGIN_PATH.
|
Addressed both comments. |
delroth
changed the title
|
I'm now a bit confused whether expressions should use the qt5 package set directly or not, see #65399 (comment). But anyway, please split the commit in two, one for each package you're updating. |
|
No more confusion, this is how to do it: #65399 (comment). |
| @@ -1,9 +1,9 @@ | |||
| { stdenv, fetchurl, pkgconfig, cmake, glib, boost, libsigrok | |||
| , libsigrokdecode, libserialport, libzip, udev, libusb1, libftdi1, glibmm | |||
| , pcre, librevisa, python3, qtbase, qtsvg | |||
| , pcre, librevisa, python3, qt5, qtbase, qtsvg | |||
There was a problem hiding this comment.
Suggested change
| , pcre, librevisa, python3, qt5, qtbase, qtsvg | |
| , pcre, librevisa, python3, mkDerivation, qtbase, qtsvg |
| }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| qt5.mkDerivation rec { |
There was a problem hiding this comment.
Suggested change
| qt5.mkDerivation rec { | |
| mkDerivation rec { |
| @@ -1,7 +1,7 @@ | |||
| { stdenv, fetchFromGitHub, cmake, pkgconfig, lxqt, libpulseaudio, | |||
| pcre, qtbase, qttools, qtx11extras }: | |||
| pcre, qt5, qtbase, qttools, qtx11extras }: | |||
There was a problem hiding this comment.
Suggested change
| pcre, qt5, qtbase, qttools, qtx11extras }: | |
| pcre, mkDerivation, qtbase, qttools, qtx11extras }: |
|
|
||
| stdenv.mkDerivation rec { | ||
| qt5.mkDerivation rec { |
There was a problem hiding this comment.
Suggested change
| qt5.mkDerivation rec { | |
| mkDerivation rec { |
|
We should never use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I've noticed both of these apps don't start anymore due to missing Qt plugin path.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)