Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustracer: 2.0.14 -> 2.1.22 #65369

Closed
wants to merge 4 commits into from
Closed

rustracer: 2.0.14 -> 2.1.22 #65369

wants to merge 4 commits into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jul 25, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
rust: switch to autoPatchelfHook in binaryBuild
2c3e31e 
- less code
- works also with rust-nightly
@Mic92
rust-nightly-bin: init at 2019-07-24
bfe3134 
Now required for rust-racer to build.
@Mic92
buildRustPackage: set CARGO_HOME for build artificats
ab3fff9 
By default rust tries to write them to $HOME/.cargo.
This is the case for rust-nightly.
@Mic92
rustracer: 2.0.14 -> 2.1.22
afbf54d
@Mic92 Mic92 requested a review from LnL7 as a code owner July 25, 2019 12:02
@Mic92 Mic92 changed the title Rustracer rustracer: 2.0.14 -> 2.1.22 Jul 25, 2019
@ofborg ofborg bot added the 6.topic: rust label Jul 25, 2019
@Mic92
Copy link
Member Author

Mic92 commented Jul 25, 2019

Current status: builds, but have not actually tested if it finds the rust src.

@Mic92
Copy link
Member Author

Mic92 commented Jul 30, 2019

super-seeded by #65596

@Mic92 Mic92 closed this Jul 30, 2019
@Mic92 Mic92 deleted the rustracer branch July 23, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
6.topic: rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Mic92