Nice, sounds good to me, I didn't even realize this problem was so prevalent in nixpkgs

@GrahamcOfBorg build i810switch

Where do all the rebuilds come from?

@infinisil this is a semantic change in that "" includes indentation and '''' does not

Yes, but even still you only changed about 70 files, but the @GrahamcOfBorg evaluation identified over 2500 packages as needing a rebuild (see https://gist.github.com/GrahamcOfBorg/dee66ed5bcce589dd91d376878215a89). I'm wondering which parts of your changes caused this many. Probably some dependency that's used by many packages

Why were some of the enable options changed to a multi-line string with only one line of content, whereas others were changed to a simple string? (e.g. memcached vs yandex-disk or bind)

The rebuilds is caused because the '' string type removes indentation, and thus the derivation is different. See e.g. https://github.com/NixOS/nixpkgs/pull/65367/files#diff-a7c4646d4130686ce08465f99cc70c97

Yes I got that @FRidh, but I'm asking for why there are so many rebuilds, not why there are at all.

Among others, git changed because it depends on docbook_xml_dtd_412, which had its indentation changed.

@GrahamcOfBorg eval

What's the best way forward? Should we wait for a git update? Do the changes look acceptable other than the large number of rebuilds?

I guess wxwidgets.

There are merged conflicts now.

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

This is going to break again pretty soon after updating. Is it scriptable?

@Lucus16 please solve the many merge conflicts and I'll merge it.

I marked this as stale due to inactivity. → More info