Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update moto #65318

Merged
merged 2 commits into from Jul 24, 2019
Merged

Update moto #65318

merged 2 commits into from Jul 24, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 23, 2019 •
edited

Motivation for this change

Partially help with #65287

backports isn't need by python3, while editing decided to:

  • update the package
  • add tests
  • groom the dependencies.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
# nix path-info -Sh ....
/nix/store/jy0yqccn70mk7h1837rbdpvj74xfhw63-python2.7-moto-1.3.8         212.9M
/nix/store/f38r2ixcjnviq5vnc3ia4vk4mxzf3353-python2.7-moto-1.3.10        214.4M

/nix/store/9dyr50mfa43jbf5g84nq4svdpfl8i3fk-python3.7-moto-1.3.8         210.3M
/nix/store/pgnljjwla7a9iqkd04lzh1x5pbzag872-python3.7-moto-1.3.10        211.8M

$ ./result/bin/moto_server
 * Running on http://127.0.0.1:5000/ (Press CTRL+C to quit)

@jonringer jonringer requested a review from FRidh as a code owner July 23, 2019 23:24
@FRidh FRidh merged commit d12733f into NixOS:master Jul 24, 2019
@FRidh FRidh mentioned this pull request Jul 24, 2019
Merged
11 tasks
@jonringer jonringer deleted the update-moto branch December 1, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh