New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There are 22 known save games that crash OpenTTD (latest master) on load. #7602
Comments
Version of OpenTTDOpenTTD 1.9.2 (stable release) Save games that don't crash in this version
Save games that still crash in this version
Save games that fail to load
|
Note that 1.9.2 is a release build and has assertions disabled. This means it will less aggressively crash, but the invalid values might cause more subtle issues later. |
Version of OpenTTD20190707-master-g1e723934a1 New crashed savegame
|
Uhm, what exactly are you trying to do here? there is a huge difference between trying to fix a bug that might corrupt a savegame or trying to load a already corrupted savegame to undo the corruption. that second part is never really a goal for anyone. |
I agree that repairing corrupted savegames should not be a goal as such. There's room for exceptions if a released version that was out for a long time had a bug that produced a large number of corrupted savegames, but one-offs are noise and would only add unnecessary complexity to the saveload code. |
If it loads in 1.9.2, then yes it's very much valid and should load in master. There were known issues with the k-d tree loading, some of which was fixed, and likely issues with other big things that have been added... |
Not very useful in current state, so closing. |
Version
c1d26d8 (2019-05-19)
Expected results
The (22+) savegames listed below don't crash.
Actual results
The savegame 'crash.sav' (!Disconnecting train #964) crashes while loading with
Assertion failed at line 205 of d:\a\1\s\src\track_func.h: tracks == INVALID_TRACK_BIT || (tracks != TRACK_BIT_NONE && KillFirstBit(tracks & TRACK_BIT_MASK) == TRACK_BIT_NONE)
. Crash info has been generated.The savegame 'crash.sav' (Crash: Disconnecting road vehicle. #1627) crashes while loading with
Disconnecting road vehicle.
Crash info has been generated.The savegame 'crash.sav' (fatal application failure #1767) crashes while loading with
Assertion failed at line 1035 of d:\a\1\s\src\newgrf_engine.cpp: !(e->u.air.subtype & AIR_CTOL)
. Crash info has been generated.The savegame 'Screenshot Apr 4th, 1976.sav' (truck got a non-existing cargo #6169) crashes with
Assertion failed at line 305 of d:\a\1\s\src\cargopacket.h: this->action_counts[MTA_KEEP] + this->action_counts[MTA_DELIVER] + this->action_counts[MTA_TRANSFER] + this->action_counts[MTA_LOAD] == this->count
when Road Vehicle 3 starts to unload at Wroclaw Woods. Workaround: Send Road Vehicle 3 to depot and sell/replace the vehicle. Crash info has been generated.The savegame 'crash.sav' (Loading savegame causes a crash. #5965) loads fine, but crashes with
Assertion failed at line 113 of d:\a\1\s\src\pool_type.hpp: index < this->first_unused
when you zoom out, scroll near certain places, or unpause the game. No crash info has been generated.The savegame 'TRT03.SV1' (Loading savegame causes a crash. #5965) loads fine, but as soon as you unpause the game, it crashes with
Assertion failed at line 225 of d:\a\1\s\src\ground_vehicle.hpp: this->z_pos == GetSlopePixelZ(this->x_pos, this->y_pos)
. Crash info has been generated.The savegame 'TRT01.SV1' (Savegames Failing to Load #5306) crashes while loading with
Assertion failed at line 4036 of d:\a\1\s\src\station_cmd.cpp: st->facilities == (FACIL_AIRPORT | FACIL_DOCK) && st->airport.type == AT_OILRIG
. Crash info has been generated.The savegame 'ThunderHammer.sav' (Savegame not working for me on two computers - but works for others #5305) crashes while loading with
Assertion failed at line 113 of d:\a\1\s\src\core\pool_type.hpp: index < this->first_unused
. Crash info has been generated.The savegame 'Tax Fiddlers Anonymous, 31st Jul 2056.sav' (Assertion error on loading old game #5232) crashes while loading with
Assertion failed at line 433 of d:\a\1\s\src\core\kdtree.hpp: this->Count() > 0
. When I try to do the emergency savegame, it fails with two Windows-style "OpenTTD has stopped working" error messages in a row. Crash info has been generated.The savegame 'crash.sav' (Assertion failed after loading an earlier savegame with NewGRF #4723) loads fine, but after a few game ticks crashes with
Assertion failed at line 133 of d:\a\1\s\src\pathfinder\follow_track.hpp: ...
No crash info has been generated.The savegame 'crash.sav' (Came crashes for unknown reason #4683) loads fine, but after a couple of game days (25th Jan 2028), crashes with
Assertion failed at line 74 of d:\a\1\s\src\yapf\yapf_ship.cpp: IsValidTrackDir(trackdir)
(if using YAPF, edit: NPF crashes as well). No crash info has been generated.The savegame 'MC Transport.sav' (Crash #4524) crashes while loading with
Assertion failed at line 114 of d:\a\1\s\src\gamelog.cpp: _gamelog_action_type == GLAT_NONE
. Crash info has been generated.The savegame 'MC Transport-fixed2.sav' (Crash #4524) crashes while loading with
Assertion failed at line 84 of d:\a\1\s\src\bitmap_type.h: this->Contains(tile)
Crash info has been generated.The savegame 'Islanders Ltd., 18-04-2221.sav' (crash when unpausing old savegame #3970) loads fine, but crashes after a couple of game days (19th Apr 2221) with
Assertion failed at line 263 of d:\a\1\s\src\vehicle.cpp: (this->vehstatus & VS_CRASHED) == 0
. This assert is probably triggered by a bugged train in a depot at (412,352). Crash info has been generated.The savegame 'crash.sav' (Crash while loading (very) old savegame #3863) crashes while loading with a
Disconnecting train
error. No crash info has been generated.The savegame 'TRT01.SV1' (TTD savegame crashes after a short time #3601) crashes while loading with
Assertion failed at line 4036 of d:\a\1\s\src\station_cmd.cpp: st->facilities == (FACIL_AIRPORT | FACIL_DOCK) && st->airport.type == AT_OILRIG
. Crash info has been generated.All of the (3) 'crash.sav' savegames from (Assertion v->time_counter !=0 failed when rearranging path signals #3422) crash while loading with
Assertion failed at line 1937 of d:\a\1\s\src\economy.cpp: v->load_unload_ticks != 0
. No crash info has been generated for either of those savegames.The savegame 'totr.sav' (rewrite tunnel bridge enter proc #3304) crashes while loading with a
Disconnecting train
error. Crash info has been generated.The next 6 savegames from (Game Crash after loading savegame after closing program. #3049, Assertion failed at ..\src\economy.cpp:1540: front_v->cargo_payment == NULL #3046) crash after a few days with
Assertion failed at line 1271 of d:\a\1\s\src\economy.cpp: front_v->cargo_payment == nullptr
:The savegame 'crash.sav' (Deleting PBS-Signals can crash the game in some situations #2666) loads fine, but crashes with
Assertion failed at line 1621 of d:\a\1\s\src\economy.cpp: front->current_order.IsType(OT_LOADING)
when Train 5 starts loading/unloading. Crash info has been generated.The savegame 'TRT08.SV1' (Loading TTD savegame error #2560) crashes while loading with
Assertion failed at line 4036 of d:\a\1\s\src\station_cmd.cpp: st->facilities == (FACIL_AIRPORT | FACIL_DOCK) && st->airport.type == AT_OILRIG
. Crash info has been generated.The savegame 'Standard Transport, 20th Dec 1989' (Unable to remove rail/road tile that I created. #2311) loads fine, but can crash in two possible ways (both caused by removing level crossing tiles)
Assertion failed at line 113 of d:\a\1\s\src\pool_type.hpp: index < this->first_unused
Crash info has been generated.Assertion failed at line 310 of d:\a\1\s\src\company_cmd.cpp: owner < OWNER_END
Crash info has been generated.Steps to reproduce
Load each of the (22) savegames listed above and follow that savegame's specific crash-reproduction directions (if any).
The text was updated successfully, but these errors were encountered: