Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.moto: fix description #65365

Merged
merged 1 commit into from Jul 25, 2019
Merged

pythonPackages.moto: fix description #65365

merged 1 commit into from Jul 25, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

While doing #65318 forgot to change the description, it just kinda "looked right" until I reviewed the merge. Sorry ;(

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner July 25, 2019 09:10
@Mic92 Mic92 merged commit 2f55e70 into NixOS:master Jul 25, 2019
@jonringer
Copy link
Contributor Author

Wow, that was the fastest merge I've seen, <2 mins xD

@Mic92
Copy link
Member

Mic92 commented Jul 26, 2019

I think the record in nixpkgs was under 10s. But well, the change was rather trival.

@jonringer jonringer deleted the moto-meta branch December 1, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @Mic92