Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.gtop: init at 1.0.0 #65306

Merged
merged 3 commits into from Aug 25, 2019
Merged

nodePackages.gtop: init at 1.0.0 #65306

merged 3 commits into from Aug 25, 2019

Conversation

tfc
Copy link
Contributor

@tfc tfc commented Jul 23, 2019

Motivation for this change

This PR adds gtop to the nodePackages list. It is a system monitoring dashboard for the terminal.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tfc
Copy link
Contributor Author

tfc commented Aug 6, 2019

I need to (and will) rebase this, but is there anything that keeps this from being merged? I would like to avoid rebasing this every few weeks.

@tfc
Copy link
Contributor Author

tfc commented Aug 6, 2019

rebased

@tfc
Copy link
Contributor Author

tfc commented Aug 23, 2019

@globin @Ma27 @domenkozar @adisbladis any chance of merging this?

ivan
ivan suggested changes Aug 23, 2019
View reviewed changes
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is a program for end users: can you also add inherit (nodePackages) gtop; to all-packages.nix?

@ivan
Copy link
Member

ivan commented Aug 23, 2019

Built and tested locally on x86_64 NixOS, appears to work fine.

@tfc
Copy link
Contributor Author

tfc commented Aug 23, 2019

@ivan thx for the suggestion! done.

@ivan
Copy link
Member

ivan commented Aug 23, 2019

@GrahamcOfBorg build gtop

@globin globin merged commit 6adb914 into NixOS:master Aug 25, 2019
@tfc tfc deleted the nodejs-gtop branch August 25, 2019 16:19
@dotlambda dotlambda mentioned this pull request Jul 31, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan ivan ivan approved these changes

@globin globin globin approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tfc @ivan @globin