hyperkit: init at 0.20190201 #65357
hyperkit: init at 0.20190201 #65357
Conversation
nicknovitski
force-pushed
the
init-hyperkit
branch
from
7979d80
to
9e0400f
Compare
nicknovitski
force-pushed
the
init-hyperkit
branch
from
9e0400f
to
a97f9fa
Compare
|
Are there any other changes I should make? |
Based on Nick's nixpkgs PR here: NixOS/nixpkgs#65357
| substituteInPlace Makefile \ | ||
| --replace 'shell git describe --abbrev=6 --dirty --always --tags' "v${version}" \ | ||
| --replace 'shell git rev-parse HEAD' "${src.rev}" \ | ||
| --replace 'PHONY: clean' 'PHONY:' |
There was a problem hiding this comment.
Why are you are making the clean target non-phony here?
| --replace 'shell git describe --abbrev=6 --dirty --always --tags' "v${version}" \ | ||
| --replace 'shell git rev-parse HEAD' "${src.rev}" \ | ||
| --replace 'PHONY: clean' 'PHONY:' | ||
| make src/include/xhyve/dtrace.h |
There was a problem hiding this comment.
Won't this automatically happen during the build anyways, so is this needed here?
| homepage = https://github.com/moby/hyperkit; | ||
| maintainers = with maintainers; [ nicknovitski ]; | ||
| platforms = platforms.darwin; | ||
| license = licenses.bsd3; |
There was a problem hiding this comment.
as far as I can see, their current license (from the README.md) looks more like bsd2.
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
|
I'm not sure how big the gap is here now, especially over time (nor do I know anything about the software--I just found this PR when I had to go install hyperkit as a dependency to try something else out), but it seems like a shame that this got bogged down. |
stale
bot
removed
the
2.status: stale
It looks like that (docker-machine/hyperkit.nix) is a docker-machine driver for this. I'll rephrase in relation to homebrew's formula, since they appear to have both:
|
You can pick it up if you want. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing due to inactivity from author. |
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)[ ] Tested compilation of all pkgs that depend on this change usingnix-shell -p nix-review --run "nix-review wip"./result/bin/)[ ] Determined the impact on package closure size (by runningnix path-info -Sbefore and after)[ ] Ensured that relevant documentation is up to date