[WIP]: Rewritting to use boto3 #1186
Conversation
|
I'd like to see #1179 finalized and get this PR targeting AWS plugin rather than merging this. Sorry for the extra work here, but in the long run I think you'll get faster response on major PRs like this when they only affect one backend. |
|
@disassembler the plugin architecture is orthogonal to this change though, I see that it still uses the unsupported boto package (which is a blocker for Python 3 migration) and still doesn't work correctly with assumeRole/MFA. If that's the way it will be restructured, perhaps my changes can be adapted to the aws plugin it seems like it was mostly moving aws components as is to the new repo. Edit: NVM looks like you said the same thing, I'll see how hard it would be to get this adapted to the new repo, although since it is a separate repository I might not get much help from git in doing that :/ |
|
@disassembler so I moved my patches to nixops-aws, my PR is here: NixOS/nixops-aws#1 |
|
So can we close this one? |
|
Yes, closing it. |
The way how my AWS accounts are setup (assumeRole + MFA) makes it impossible to use old version of nixops. I initially tried to add an option to specify a profile, but turns out that old boto doesn't seem to support this kind of setup (since it was introduced later on) and it mandated porting to boto3.
So this version works fine with assumeRole + MFA and I also added an option to use the same cache that
awscommand uses. That way you don't have to enter MFA every for every single command.Currently all of the commands that I used appear to be working, these are:
If you can, please test it (clone my branch and run
nix-env -f release.nix -iA build.<your platform>) if there are still broken commands let me know otherwise perhaps this can be merged.