Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-tools: add clangd #65321

Closed
wants to merge 1 commit into from
Closed

clang-tools: add clangd #65321

wants to merge 1 commit into from

Conversation

peterhoeg
Copy link
Member

Motivation for this change

clang-tools doesn't have the clangd binary although it is built.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member Author

Cc: @aherrmann

@thomasjm
Copy link
Contributor

It looks like you're missing a backslash on line 18.

@peterhoeg
Copy link
Member Author

Thanks for picking up on that. It's part of my get-stuff-that-has-lingered-for-far-too-long-locally-upstreamed-for-next-release drive.

@peterhoeg
Copy link
Member Author

@GrahamcOfBorg build clang-tools

@teto
Copy link
Member

teto commented Jul 24, 2019

while at it you could split name into pname / version.

@peterhoeg peterhoeg closed this Jul 24, 2019
@peterhoeg peterhoeg deleted the f/clang branch July 24, 2019 08:32
@peterhoeg peterhoeg mentioned this pull request Jul 24, 2019
Merged
10 tasks
@peterhoeg peterhoeg restored the f/clang branch July 25, 2019 03:10
@peterhoeg peterhoeg deleted the f/clang branch July 25, 2019 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @thomasjm @teto