Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neo.map: fix URL #61239

Closed
wants to merge 1 commit into from
Closed

neo.map: fix URL #61239

wants to merge 1 commit into from

Conversation

nixbitcoin
Copy link
Contributor

@nixbitcoin nixbitcoin commented May 10, 2019

Current URL is no longer available, due to the migration from svn to github.

Occurred during testing of fort-nix/nix-bitcoin#48

Motivation for this change

#60201 seems to have stalled. This PR commits @samsonan-it's fix and @teto's & @matthiasbeyer's suggested changes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 10, 2019

name inside fetchurl is not the attribute name for mkDerivation.
Let's keep fixing this through the original PR

@c0bw3b c0bw3b closed this May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants