Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kube3d #61190

Merged
merged 1 commit into from Jul 1, 2019
Merged

Kube3d #61190

merged 1 commit into from Jul 1, 2019

Conversation

ngerstle-cognite
Copy link
Contributor

@ngerstle-cognite ngerstle-cognite commented May 9, 2019 •
edited

Motivation for this change

Add the k3d (https://github.com/rancher/k3d) tool.
The k3d tool spins up a k3s kubernetes cluster.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ngerstle-cognite
Copy link
Contributor Author

For reference, definitions generated by:

  • checking out v1.1.0 of k3d: git clone https://github.com/rancher/k3d.git && git checkout v1.1.0
  • running vgo2nix in checked out repository to generate deps.nix: cd k3d && vgo2nix
  • writing default.nix

jlesquembre
jlesquembre reviewed May 12, 2019
View reviewed changes
Copy link
Member

@jlesquembre jlesquembre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, I also wanted to try k3s on NixOS

pkgs/applications/networking/cluster/kube3d/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/cluster/kube3d/default.nix Show resolved Hide resolved
@kuznero
Copy link
Member

kuznero commented Jun 2, 2019

Thanks for PR! Looking forward to k3s in NixOS too!

@ngerstle-cognite ngerstle-cognite mentioned this pull request Jun 5, 2019
Merged
10 tasks
@ngerstle-cognite
Copy link
Contributor Author

What's remaining to get this merged?

@ngerstle-cognite
Copy link
Contributor Author

bump??

@ngerstle-cognite
Copy link
Contributor Author

@etu Can I ask you to help me get this merged?
Is there anything you'd like to to fix up first?

@etu
Copy link
Contributor

etu commented Jul 1, 2019

@ngerstle-cognite Could you squash the commits to a single commit?

@ngerstle-cognite
Copy link
Contributor Author

@etu squashed into a single commit, fresh off master.

@etu
Copy link
Contributor

etu commented Jul 1, 2019

@GrahamcOfBorg build kube3d

@etu etu merged commit 4cfef32 into NixOS:master Jul 1, 2019
@ngerstle-cognite
Copy link
Contributor Author

Thanks @etu !

@ngerstle-cognite ngerstle-cognite deleted the kube3d branch July 1, 2019 09:41
@etu
Copy link
Contributor

etu commented Jul 1, 2019

No worries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuznero kuznero kuznero left review comments

@etu etu etu left review comments

@jlesquembre jlesquembre jlesquembre left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ngerstle-cognite @kuznero @etu @jlesquembre