Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds pkgsCross.gnu32 and pkgsCross.gnu64 platforms #61038

Merged
merged 1 commit into from May 9, 2019
Merged

Adds pkgsCross.gnu32 and pkgsCross.gnu64 platforms #61038

merged 1 commit into from May 9, 2019

Conversation

lionello
Copy link
Contributor

@lionello lionello commented May 6, 2019

Motivation for this change

Current Nixpkgs has many platforms listed under pkgsCross as targets, except the most common x86_64-unknown-linux-gnu and i686-unknown-linux-gnu. This MR adds those two for cross compiling to linux from, for example, Darwin.

For successful cross compiling, one of the first things that needs to be fixed is binutils, which currently does't compile on Darwin, so this MR alone does not help yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lionello
Copy link
Contributor Author

lionello commented May 9, 2019

Ping @adisbladis What do you think?

@matthewbauer matthewbauer merged commit 32b4311 into NixOS:master May 9, 2019
@lionello lionello deleted the gnu32-gnu64 branch May 9, 2019 15:45
@adisbladis
Copy link
Member

For successful cross compiling, one of the firsthings that needs to be fixed is binutils, which currently does't compile on Darwin, so this MR alone does not help yet.

This already helps for other use cases like cross compiling x86_64 from arm. Big thumbs up from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lionello @adisbladis @matthewbauer