Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scopes: init #61209

Closed
wants to merge 3 commits into from
Closed

scopes: init #61209

wants to merge 3 commits into from

Conversation

jacereda
Copy link
Contributor

@jacereda jacereda commented May 9, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Zer0-
Copy link
Contributor

Zer0- commented May 10, 2019

I built and ran "hello world" with this, but I don't know the scopes lang so I didn't seriously test it.

@jacereda
Copy link
Contributor Author

Not ready yet, It won't find the libc headers on Linux. Working on it.

@jacereda
Copy link
Contributor Author

I think it should build now on Linux and Darwin.

@drewrisinger
Copy link
Contributor

@GrahamcOfBorg eval
@GrahamcOfBorg build scopes

Not sure what the exact current status of this is, but some feedback I see at first glance:

  • the commits should be rebased into one per nix file
  • PR title should be renamed to ~ scopes: init at 2019.06.13 (similar for the scopes init commit)
  • Disable aarch64 platform (e.g. in meta: platforms = [ "x86_64-linux" ... ]; (should also include Darwin, I think??)

@stale
Copy link

stale bot commented Oct 31, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 31, 2020

nativeBuildInputs = [ genie spirv-tools spirv-cross ];

buildInputs = [ llvm clang-unwrapped ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't those also native build inputs?

})
];

makefile = "Makefile";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be required for nix.

Comment on lines +49 to +53
install -d $out/bin
install -d $out/lib
cp bin/scopes $out/bin
cp bin/lib* $out/lib
cp -R lib/* $out/lib/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
install -d $out/bin
install -d $out/lib
cp bin/scopes $out/bin
cp bin/lib* $out/lib
cp -R lib/* $out/lib/
install -Dm755 bin/scopes $out/bin
install -d $out/lib
cp bin/lib* $out/lib
cp -R lib/* $out/lib/

meta = {
description = "Retargetable programming language & infrastructure";
homepage = http://scopes.rocks;
license = stdenv.lib.licenses.mit;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainers and platforms missing.

Comment on lines +3 to +4
name = "spirv-cross-${version}";
version = "2019-04-26";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "spirv-cross-${version}";
version = "2019-04-26";
pname = "spirv-cross";
version = "2019-04-26";


meta = with stdenv.lib; {
inherit (src.meta) homepage;
description = "Parse and convert SPIR-V to other shader languages";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainers and platforms missing.

)

echoCmd 'configure flags' "${flagsArray[@]}"
genie "${flagsArray[@]}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this file into the nix file.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 25, 2020
@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@dit7ya
Copy link
Member

dit7ya commented Mar 1, 2022

Hello, @jacereda, any updates on this?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 1, 2022
@jacereda
Copy link
Contributor Author

jacereda commented Mar 1, 2022

Hello, @jacereda, any updates on this?

I'm exploring the Guix land and can't fix this, sorry. Feel free to take over or close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants