Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/timvisee/ffsend/releases/tag/v0.2.46
Extend the xclip/xsel support to all BSD variants and add BSD to the supported platforms list.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)A change in this version tweaks clipboard support for all BSD variants, so I figured it was safe to declare that this supported all BSD variants. It seems there's no pre-built
lib.platforms
entry for BSD, just for specific BSD flavors, which is why I ended up using[ stdenv.lib.systems.inspect.patterns.isBSD ]
. I wasn't sure if there's a better way to do this. I'm also wondering if I should just give up and useplatforms.unix
, except I don't know ifffsend
works on Cygwin (which is part ofplatforms.unix
).