Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffsend: 0.2.45 -> 0.2.46 #60945

Merged
merged 1 commit into from May 10, 2019
Merged

ffsend: 0.2.45 -> 0.2.46 #60945

merged 1 commit into from May 10, 2019

Conversation

lilyball
Copy link
Member

@lilyball lilyball commented May 4, 2019

Motivation for this change

https://github.com/timvisee/ffsend/releases/tag/v0.2.46

Extend the xclip/xsel support to all BSD variants and add BSD to the supported platforms list.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

A change in this version tweaks clipboard support for all BSD variants, so I figured it was safe to declare that this supported all BSD variants. It seems there's no pre-built lib.platforms entry for BSD, just for specific BSD flavors, which is why I ended up using [ stdenv.lib.systems.inspect.patterns.isBSD ]. I wasn't sure if there's a better way to do this. I'm also wondering if I should just give up and use platforms.unix, except I don't know if ffsend works on Cygwin (which is part of platforms.unix).

Extend the xclip/xsel support to all BSD variants and update the
platforms list to `platforms.unix`.
@c0bw3b c0bw3b merged commit d02d55d into NixOS:master May 10, 2019
@lilyball lilyball deleted the ffsend branch May 11, 2019 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants