[r19.03 backport] leptonica: patch multiple CVEs #61217
Merged
+127
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0bw3b
added
1.severity: security
|
@GrahamcOfBorg build leptonica |
|
Huh I'm getting this wrong output hash problem on another machine of mine too - maybe I made a mistake... |
this should fix CVE-2018-3836, CVE-2018-7186, CVE-2018-7247 & CVE-2018-7440 a fix for CVE-2018-7441 & CVE-2018-7442 is *not* included as its patches are very wide-ranging also enable tests to give confidence that I'm not completely butchering the code
risicle
force-pushed
the
ris-leptonica-fix-19.03-backport
branch
from
1443930 to
0861ad5
Compare
|
Yup must have poisoned my cache somehow - fixed now. |
|
And I've also checked |
|
@GrahamcOfBorg build leptonica |
c0bw3b
approved these changes
May 10, 2019
|
Result of 14 package were build:
|
|
It should be noted that |
This was referenced May 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As I note in #60392 (comment) (whose PR should really be merged), the commits fixing CVE-2018-7441 & CVE-2018-7442 don't feel practical to backport and the fix for CVE-2017-18196 is yet to be found.
However this should fix CVE-2018-3836, CVE-2018-7186, CVE-2018-7247 & CVE-2018-7440.
I've also enabled the tests to give me some confidence that I'm not completely butchering the code.
Haven't yet completed aBuilds for me non-nixos linux x86_64nox-reviewfor this.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)