Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arandr: 0.1.9 -> 0.1.10 #61216

Merged
merged 1 commit into from May 10, 2019
Merged

arandr: 0.1.9 -> 0.1.10 #61216

merged 1 commit into from May 10, 2019

Conversation

endgame
Copy link
Contributor

@endgame endgame commented May 9, 2019

Motivation for this change

Closes #60456 - this PR does the version bump but we also need to add some deps and switch python version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-ryantm @endgame
arandr: 0.1.9 -> 0.1.10
e80acad 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/arandr/versions

arandr 0.1.10 needs python3, so switch python version too.
@ofborg ofborg bot requested a review from domenkozar May 9, 2019 22:52
@Zer0-
Copy link
Contributor

Zer0- commented May 10, 2019

I built and ran arandr from this branch, looks good to me.

@c0bw3b c0bw3b mentioned this pull request May 10, 2019
Closed
@c0bw3b
Copy link
Contributor

c0bw3b commented May 10, 2019 •
edited

Tested locally too and it works as intended.
It's missing some icons in the toolbar though, and it logs warnings

(arandr:32601): Gtk-WARNING **: 17:16:25.179: Error loading theme icon 'document-new' for stock: Icon 'document-new' not present in theme Adwaita
(arandr:32601): Gtk-WARNING **: 17:16:25.180: Error loading theme icon 'document-open' for stock: Icon 'document-open' not present in theme Adwaita
(arandr:32601): Gtk-WARNING **: 17:16:25.180: Error loading theme icon 'document-save-as' for stock: Icon 'document-save-as' not present in theme Adwaita

@Zer0-
Copy link
Contributor

Zer0- commented May 10, 2019

c0bw3b, this thread regarding icons is relevant.

@Ma27
Copy link
Member

Ma27 commented May 10, 2019

Built and tested locally 👍
Also great that another package uses gtk3 and gets rid of python2!

c0bw3b, this thread regarding icons is relevant.

We had a similar discussion in #53857, in the end I guess that it should be fine to install GNOME's icon themes globally.

@Ma27 Ma27 merged commit 0285c61 into NixOS:master May 10, 2019
@Ma27
Copy link
Member

Ma27 commented May 10, 2019

@endgame thanks!

@vbgl
Copy link
Contributor

vbgl commented May 20, 2019

Global installation of the icon set (as described in that discussion) fixes the missing icons.

However, the GTK dialog boxes do not work: trying to open a file (through the Layout → Open menu or through the keyboard shortcut) results in a pathetic crash:

(arandr:28747): GLib-GIO-ERROR **: 08:12:27.103: No GSettings schemas are installed on the system

@endgame endgame deleted the arandr branch May 20, 2019 08:38
@endgame endgame mentioned this pull request May 20, 2019
Merged
10 tasks
@endgame
Copy link
Contributor Author

endgame commented May 20, 2019

Thanks @vbgl . I have tried to fix this in #61738 , are you able to test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zer0- Zer0- Zer0- approved these changes

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@endgame @Zer0- @c0bw3b @Ma27 @vbgl @r-ryantm