Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtl8192eu: update at 4.4.1 #61195

Merged
merged 2 commits into from May 27, 2019
Merged

rtl8192eu: update at 4.4.1 #61195

merged 2 commits into from May 27, 2019

Conversation

troydm
Copy link
Contributor

@troydm troydm commented May 9, 2019 •
edited

Motivation for this change

Latest commit in rtl8192eu module github repo contains fixes for compiling with 5.0 and 5.1 kernels so I've just updated git hash codes

Things done

Updated git commit hashes to checkout latest rtl8192eu kernel module source code

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

veprbl
veprbl approved these changes May 27, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From nix-review:

2 package failed to build:
linuxPackages-libre.rtl8192eu linuxPackages_testing_hardened.rtl8192eu

12 package were build:linuxPackages.rtl8192eu linuxPackages_4_14.rtl8192eu linuxPackages_4_4.rtl8192eu linuxPackages_4_9.rtl8192eu linuxPackages_5_0.rtl8192eu linuxPackages_5_1.rtl8192eu linuxPackages_hardened.rtl8192eu linuxPackages_latest-libre.rtl8192eu linuxPackages_latest_hardened.rtl8192eu linuxPackages_latest_xen_dom0.rtl8192eu linuxPackages_testing_bcachefs.rtl8192eu linuxPackages_xen_dom0.rtl8192eu

@veprbl veprbl merged commit 7e3dc85 into NixOS:master May 27, 2019
veprbl pushed a commit that referenced this pull request May 27, 2019
@troydm @veprbl
rtl8192eu: 4.4.1 -> 4.4.1.20190319 (#61195)
1bc317d 
(cherry picked from commit 7e3dc85)
@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@troydm @veprbl