Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncthing: 1.1.1 -> 1.1.3 #61314

Merged
merged 1 commit into from May 12, 2019
Merged

syncthing: 1.1.1 -> 1.1.3 #61314

merged 1 commit into from May 12, 2019

Conversation

jabranham
Copy link
Contributor

Motivation for this change

Upstream release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

tomberek
tomberek approved these changes May 11, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs, on Ubuntu. Reverse dependencies function.

@Lassulus
Copy link
Member

tested with nix-review, syncthing runs, but syncthing-gtk throws:

[nix-shell:~/.cache/nix-review/pr-61314-1]$ syncthing-gtk 
Traceback (most recent call last):
  File "/nix/store/czb6i7j5bv0602djxz478yqbbh0h9kcq-syncthing-gtk-0.9.4/bin/..syncthing-gtk-wrapped-wrapped", line 38, in <module>
    from syncthing_gtk.app import App
  File "/nix/store/czb6i7j5bv0602djxz478yqbbh0h9kcq-syncthing-gtk-0.9.4/lib/python2.7/site-packages/syncthing_gtk/app.py", line 9, in <module>
    from gi.repository import Gtk, Gio, Gdk, GLib, GdkPixbuf
  File "/nix/store/fdb5b6s3ns0mc9m843qpjg4j9l7d785i-python2.7-pygobject-3.32.1/lib/python2.7/site-packages/gi/importer.py", line 140, in load_module
    raise ImportError(e)
ImportError: Typelib file for namespace 'Pango', version '1.0' not found

@tomberek
Copy link
Contributor

@Lassulus I get that same error, but it is not a regression due to this PR. Building with syncthing-1.1.1 also has that issue.

@Lassulus
Copy link
Member

Indeed, well syncthing-gtk needs some updating anyway.
thanks!

@Lassulus Lassulus merged commit 0695bb6 into NixOS:master May 12, 2019
@jabranham jabranham deleted the syncthing branch May 13, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jabranham @Lassulus @tomberek