sqlitebrowser: 3.10.1 -> 3.11.2 #61287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
reviewed
May 14, 2019
The latest releases of `sqlitebrowser` contain several new features like a dark mode, improved CSV import/export and a lot of new bugfixes: https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/v3.11.2 https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/v3.11.1 https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/v3.11.0 Also some minor changes were applied to the package definition: * Using the `pname`/`version` convention now. * Use internal `qscintilla` rather than our package to fix the build (sqlitebrowser/sqlitebrowser#1348 (comment)). This can probably be removed when NixOS#56034 is merged. * Dropped patch which removed Test and Print support as QT 5.12 is now used to build the application.
|
@FRidh anything else or is this mergeable now? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The latest releases of
sqlitebrowsercontain several new features likea dark mode, improved CSV import/export and a lot of new bugfixes:
https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/v3.11.2
https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/v3.11.1
https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/v3.11.0
Also some minor changes were applied to the package definition:
pname/versionconvention now.qscintillarather than our package to fix the build(fatal error: Qsci/qscilexerjson.h: No such file or directory sqlitebrowser/sqlitebrowser#1348 (comment)).
This can probably be removed when qscintilla: 2.9.4 -> 2.11.2 and sqlitebrowser: 3.11.2 #56034 is merged.
used to build the application.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)