Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.03] rednose: disable test suite #61238

Closed
wants to merge 1 commit into from
Closed

[19.03] rednose: disable test suite #61238

wants to merge 1 commit into from

Conversation

nixbitcoin
Copy link
Contributor

@nixbitcoin nixbitcoin commented May 10, 2019

Building nixops fails because the python test suite gets stuck. The test suite had previously been disabled for Darwin because of a similar error. So now I disabled it entirely because I was also getting an error on a Debian Linux system.

Occured during testing of fort-nix/nix-bitcoin#48

Motivation for this change

Backport of #60805
/cc @FRidh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please perform the backport as described in the nixpkgs manual.

In the future be sure to format your commit msg's like attribute_name: description.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build rednose

@nixbitcoin
Copy link
Contributor Author

nixbitcoin commented May 15, 2019

Redid the PR according to nixpkgs manual. Sorry for the confusion.

Now available at #61542.

@nixbitcoin nixbitcoin closed this May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants