Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idsk: unstable-2018-02-11 -> 0.19 #61236

Merged
merged 1 commit into from May 17, 2019
Merged

idsk: unstable-2018-02-11 -> 0.19 #61236

merged 1 commit into from May 17, 2019

Conversation

bignaux
Copy link
Contributor

@bignaux bignaux commented May 10, 2019 •
edited

Motivation for this change

fix homepage , license ( cpcsdk/idsk#6 ) and release !

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bignaux bignaux changed the title idsk: unstable-2018-02-11 > unstable-2018-11-26 idsk: unstable-2018-02-11 -> unstable-2018-11-26 May 10, 2019
@bignaux bignaux changed the title idsk: unstable-2018-02-11 -> unstable-2018-11-26 idsk: unstable-2018-02-11 -> 0.19 May 11, 2019
@bignaux
Copy link
Contributor Author

bignaux commented May 11, 2019

@GrahamcOfBorg build idsk

JohnAZoidberg
JohnAZoidberg approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I ran the tests they run on Travis manually and all work.

@c0bw3b c0bw3b merged commit a468035 into NixOS:master May 17, 2019
@bignaux bignaux deleted the idsk branch May 18, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bignaux @JohnAZoidberg @c0bw3b