Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bettercap: 2.11 -> 2.24 #61215

Merged
merged 2 commits into from May 17, 2019
Merged

bettercap: 2.11 -> 2.24 #61215

merged 2 commits into from May 17, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 9, 2019

Motivation for this change

Seems to work?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 9, 2019

Duplicate of #61154

@c0bw3b c0bw3b marked this as a duplicate of #61154 May 9, 2019
@c0bw3b c0bw3b closed this May 9, 2019
@fadenb fadenb mentioned this pull request May 11, 2019
Closed
10 tasks
@fadenb
Copy link
Contributor

fadenb commented May 11, 2019

@c0bw3b can we re-open this PR?
It is better than the other one I created earlier.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 11, 2019

Sure

@c0bw3b c0bw3b reopened this May 11, 2019
@c0bw3b
bettercap: use current libusb1
2e684ba 
and not the old compat-API with v0.1
@c0bw3b c0bw3b merged commit a911031 into NixOS:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @c0bw3b @fadenb