New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mupdf: 1.14.0 -> 1.15.0 #61196
mupdf: 1.14.0 -> 1.15.0 #61196
Conversation
Drop CVE patch, presumably included since it's from their repo :). (but not mentioned in release notes online)
I checked 1.15 sources and it is indeed applied ✔️ |
} | ||
)] | ||
++ stdenv.lib.optional (!stdenv.isDarwin) ./mupdf-1.14-shared_libs.patch | ||
stdenv.lib.optional (!stdenv.isDarwin) ./mupdf-1.14-shared_libs.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the makefile and this patch is still valid & needed for 1.15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds fine on my machine with:
nix build '(with import (builtins.fetchTarball { url = "https://github.com/dtzWill/nixpkgs/archive/update/mupdf-1.15.0.tar.gz"; }) {}; pkgs.mupdf)'
And I can view a PDF with it. It seemed to produce only one output (bin), though that might be a nix build
thing?
@endgame It's a multi-output derivation so you should get several "folders" in your nix store (mupdf-1.15.0-bin, mudpf-1.15.0-dev, etc...) Result of 2 package failed to build:
7 package were build:
|
updated the PR in #68506. Wanted to run a nix-review on it but it was trying to fetch/build > 2000 packages for some reason so I ended up cancelling the session. |
Closing in favour of #68506 |
Motivation for this change
Drop CVE patch, presumably included since it's from their repo :).
(but not mentioned in release notes online)
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)