Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxmlb: 0.1.8 -> 0.1.9 #61201

Merged
merged 2 commits into from May 11, 2019
Merged

libxmlb: 0.1.8 -> 0.1.9 #61201

merged 2 commits into from May 11, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 9, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jtojnar May 9, 2019 18:15
c0bw3b
c0bw3b approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 61201 1

4 package were build:
  • discover (plasma5.discover)
  • fwupd (plasma5.discover)
  • gnome3.gnome-software (plasma5.discover)
  • libxmlb (plasma5.discover)

@c0bw3b
Copy link
Contributor

c0bw3b commented May 9, 2019 •
edited

Humm the Darwin failure was there before but let's take the opportunity of a PR to fix it?
Or rather restrict this to linux platforms. cc @jtojnar

@jtojnar
Copy link
Contributor

jtojnar commented May 10, 2019

This line should probably be cc.find_library('uuid'). But since we only use it in Linux-specific programs limiting the platforms is fine.

@c0bw3b
libxmlb: restrict to linux platforms
033e442 
It fails to build on Darwin
@c0bw3b c0bw3b merged commit 5dff8e9 into NixOS:master May 11, 2019
shinedog pushed a commit to shinedog/nixpkgs that referenced this pull request May 11, 2019
@dtzWill
libxmlb: 0.1.8 -> 0.1.9 (NixOS#61201)
c167df6 
* libxmlb: 0.1.8 -> 0.1.9

* libxmlb: restrict to linux platforms
It fails to build on Darwin
tadeokondrak pushed a commit to tadeokondrak/nixpkgs that referenced this pull request May 17, 2019
@dtzWill @tadeokondrak
libxmlb: 0.1.8 -> 0.1.9 (NixOS#61201)
fbb4b02 
* libxmlb: 0.1.8 -> 0.1.9

* libxmlb: restrict to linux platforms
It fails to build on Darwin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @c0bw3b @jtojnar