Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

viu: 0.1 -> 0.2.1 #61199

Merged
merged 1 commit into from May 10, 2019
Merged

viu: 0.1 -> 0.2.1 #61199

merged 1 commit into from May 10, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 9, 2019

Motivation for this change

https://github.com/atanunq/viu/releases/tag/v0.2.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link

ghost commented May 10, 2019 •
edited by ghost

I noticed that gif playback is still unstable: atanunq/viu#12
Otherwise it looks fine, and it doesn't seem like any functionality from 0.1 is impaired.

I'm also wondering what's up with the darwin build. If it's really just a timeout, well, rust builds can not share their dependencies :(

@dtzWill dtzWill merged commit 12939f0 into NixOS:master May 10, 2019
@dtzWill dtzWill deleted the update/viu-0.2.1 branch May 10, 2019 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dtzWill