Fix #7371: Avoid dependency on foundations of town tile during saveload #7398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still think depending on anything as extensively as this before any savegame conversion has happened is asking for trouble. |
|
I prefer this solution because it does not introduce a global state for whether to use one or another algorithm, and it does not introduce a state for whether the k-d trees are valid, since they are now always valid. |
|
This pull request has been automatically marked as stale because it has not had any activity in the last month. |
|
Needs a rebase? |
|
Hmm yes, it's victim of the docker failure |
PeterN
approved these changes
May 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is perhaps the simplest possible fix, but it also changes the position of town signs in some situations.