Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tentative WPTs for SameSiteByDefaultCookies #16779

Closed
wants to merge 1 commit into from

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

Add a virtual test suite for testing SameSiteByDefaultCookies,
which treats unspecified-SameSite cookies as if they were
SameSite=Lax (the current status quo is to treat them as if
they were SameSite=None).

This change basically copies the entire wpt/cookies/samesite
test suite into wpt/cookies/samesite-by-default. Tests in the
new directory have modified assertion expectations to match
the new behavior for unspecified-SameSite cookies, and are
marked "tentative".

Disable the regular samesite tests in the virtual test suite
with SameSiteByDefaultCookies enabled. Disable the
samesite-by-default tentative tests in the regular test suite.

Also fix one of the cookie prefix tests that fails with
SameSiteByDefaultCookies enabled, so that it passes whether or
not it is enabled.

Bug: 961439
Change-Id: Ib0cc49b8779726375adeecda9e1d3238cd7454ad

Reviewed-on: https://chromium-review.googlesource.com/1606080
WPT-Export-Revision: 66557b4a4ad35dba781e6274eaa60aa91eaffe0b

Add a virtual test suite for testing SameSiteByDefaultCookies,
which treats unspecified-SameSite cookies as if they were
SameSite=Lax (the current status quo is to treat them as if
they were SameSite=None).

This change basically copies the entire wpt/cookies/samesite
test suite into wpt/cookies/samesite-by-default. Tests in the
new directory have modified assertion expectations to match
the new behavior for unspecified-SameSite cookies, and are
marked "tentative".

Disable the regular samesite tests in the virtual test suite
with SameSiteByDefaultCookies enabled. Disable the
samesite-by-default tentative tests in the regular test suite.

Also fix one of the cookie prefix tests that fails with
SameSiteByDefaultCookies enabled, so that it passes whether or
not it is enabled.

Bug: 961439
Change-Id: Ib0cc49b8779726375adeecda9e1d3238cd7454ad
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@KyleJu
Copy link
Contributor

KyleJu commented May 14, 2019

Close this PR because the Chromium CL has been abandoned.

@KyleJu KyleJu closed this May 14, 2019
@KyleJu KyleJu deleted the chromium-export-cl-1606080 branch May 14, 2019 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants