Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tilix: 1.9.0 -> 1.9.3 #61222

Merged
merged 1 commit into from May 12, 2019
Merged

tilix: 1.9.0 -> 1.9.3 #61222

merged 1 commit into from May 12, 2019

Conversation

worldofpeace
Copy link
Contributor

https://github.com/gnunn1/tilix/releases/tag/1.9.3

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented May 10, 2019

When building locally on a x86_64-linux, the build's dependency ldc fails with the following error:

1600:  ... fail_compilation/testhtml2.html -O (-d -dw)
1600:  ... fail_compilation/testhtml3.html -O (-d -dw)
1600:  ... fail_compilation/testhtml.html -O (-d -dw)
1600: make: Leaving directory '/build/ldc-1.15.0-src/tests/d2/dmd-testsuite'
4/4 Test #1600: dmd-testsuite ....................   Passed  193.09 sec

The following tests passed:
        clean-dmd-testsuite-debug
        clean-dmd-testsuite
        dmd-testsuite-debug
        dmd-testsuite

100% tests passed, 0 tests failed out of 4

Total Test time (real) = 193.14 sec
Test project /build/ldc-1.15.0-src/build
    Start 1: build-ldc2-unittest
1/2 Test #1: build-ldc2-unittest ..............   Passed   40.02 sec
    Start 2: ldc2-unittest
2/2 Test #2: ldc2-unittest ....................Child aborted***Exception:   0.03 sec
Fatal error in EH code: DWARF header has unexpected format 2


50% tests passed, 1 tests failed out of 2

Total Test time (real) =  40.08 sec

The following tests FAILED:
          2 - ldc2-unittest (Child aborted)
Errors while running CTest
builder for '/nix/store/hxzygqhkhg4kqs2wdcmim65lp20vwbq3-ldc-1.15.0.drv' failed with exit code 8
error: build of '/nix/store/hxzygqhkhg4kqs2wdcmim65lp20vwbq3-ldc-1.15.0.drv' on 'ssh://builder' failed: builder for '/nix/store/hxzygqhkhg4kqs2wdcmim65lp20vwbq3-ldc-1.15.0.drv' failed with exit code 8
builder for '/nix/store/hxzygqhkhg4kqs2wdcmim65lp20vwbq3-ldc-1.15.0.drv' failed with exit code 1
cannot build derivation '/nix/store/qk2c8aix19jib16wywrmpanhgbsp8dpf-dmd-2.085.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/56rbbv7waxjmfgskcmlp7620bkpksi70-tilix-1.9.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/56rbbv7waxjmfgskcmlp7620bkpksi70-tilix-1.9.3.drv' failed

I'm not sure what exactly went wrong that caused the test suite to be killed. Did you experience similar issues?

@worldofpeace
Copy link
Contributor Author

worldofpeace commented May 10, 2019 •
edited

I haven't built it because I noticed it had to rebuild ldc however, I believe it fails like this on hydra as well and happened after the last staging-next iteration.

Quick check on hydra proves this is true https://nix-cache.s3.amazonaws.com/log/hxzygqhkhg4kqs2wdcmim65lp20vwbq3-ldc-1.15.0.drv

Though I'll still check locally.

Edit: can reproduce locally

cc @ThomasMader

@ThomasMader
Copy link
Contributor

I think this problem was introduced with #56744.
For now you can try to just disable the checkPhase to get the build working, but I am not sure if everything will work because to me that seems to be a problem with exceptions and if there is a general problem with those, there will be bigger trouble down the road I guess.

I am not having time to look into this for the next one or two weeks.

@worldofpeace worldofpeace mentioned this pull request May 11, 2019
Closed
@ThomasMader
Copy link
Contributor

The ldc build will be fixed after #61354 was merged.

@worldofpeace
Copy link
Contributor Author

Thanks @ThomasMader ❇️

@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg build tilix

@worldofpeace worldofpeace merged commit ffd8102 into NixOS:master May 12, 2019
@worldofpeace worldofpeace deleted the bump/tilix branch May 12, 2019 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @Ma27 @ThomasMader