Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-make: init at 0.19.1 #61265

Merged
merged 1 commit into from May 16, 2019
Merged

cargo-make: init at 0.19.1 #61265

merged 1 commit into from May 16, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented May 11, 2019

Motivation for this change

cargo-make is a Rust runner and build tool.

https://sagiegurari.github.io/cargo-make/
https://github.com/sagiegurari/cargo-make

Note:
doCheck is set as false.
Some tests fail because they need network access. However, Travis ensures a proper build.
https://travis-ci.org/sagiegurari/cargo-make/jobs/530738212
https://travis-ci.org/sagiegurari/cargo-make/jobs/530738213
https://travis-ci.org/sagiegurari/cargo-make/jobs/530738214

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xrelkd xrelkd mentioned this pull request May 13, 2019
Merged
10 tasks
@marsam
Copy link
Contributor

marsam commented May 15, 2019

@GrahamcOfBorg build cargo-make

@marsam marsam merged commit 67dc631 into NixOS:master May 16, 2019
@marsam
Copy link
Contributor

marsam commented May 16, 2019

Sorry for the delay, tested locally on NixOS and darwin.
Thanks @xrelkd! btw feel free to ping me if any PR gets stuck :)

@xrelkd
Copy link
Contributor Author

xrelkd commented May 16, 2019

@marsam Thank you very much!!

@xrelkd xrelkd deleted the add/cargo-make branch May 16, 2019 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xrelkd @marsam