Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-repo-updater: init at 0.5 #61266

Merged
merged 1 commit into from Jun 4, 2019
Merged

git-repo-updater: init at 0.5 #61266

merged 1 commit into from Jun 4, 2019

Conversation

bdesham
Copy link
Contributor

@bdesham bdesham commented May 11, 2019

Motivation for this change

Adds git-repo-updater, a Python script that fetches all available remotes and fast-forwards your local branches (whenever possible) in multiple Git repos. The executable is called gitup.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Ubuntu)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

JohnAZoidberg
JohnAZoidberg requested changes May 18, 2019
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool program :D Works fine.

pkgs/development/tools/git-repo-updater/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/development/tools/git-repo-updater/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/git-repo-updater/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/git-repo-updater/default.nix Outdated Show resolved Hide resolved
@bdesham
Copy link
Contributor Author

bdesham commented May 18, 2019

@JohnAZoidberg Thank you for the great feedback! I incorporated all of your suggestions (and removed the extra dependencies) in a new commit.

tomberek
tomberek approved these changes May 26, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs, functions as expected on Ubuntu.

@JohnAZoidberg
Copy link
Member

JohnAZoidberg commented May 26, 2019 •
edited

Please squash the commits, then it looks fine for me :)
I don't have merge privileges btw.

@bdesham
Copy link
Contributor Author

bdesham commented May 26, 2019

Squashed and rebased against the latest master 🙂

@JohnAZoidberg
Copy link
Member

I can't merge though, sorry.

@bdesham
Copy link
Contributor Author

bdesham commented May 31, 2019

@JohnAZoidberg Oh, I missed that part of your comment before. Hopefully someone with merge privileges will be along before too long…

@Ma27
Copy link
Member

Ma27 commented Jun 4, 2019

Built and tested locally 👍

@Ma27 Ma27 merged commit addb7e4 into NixOS:master Jun 4, 2019
@Ma27
Copy link
Member

Ma27 commented Jun 4, 2019

@bdesham thanks!

@bdesham bdesham deleted the add-git-repo-updater branch June 4, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@JohnAZoidberg JohnAZoidberg JohnAZoidberg approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bdesham @JohnAZoidberg @Ma27 @tomberek