Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidia-x11: Add patches for kernel 5.1. #61249

Closed
wants to merge 1 commit into from

Conversation

ambrop72
Copy link
Contributor

Fixes #61165

Produced this on my own based on the errors and kernel changes:

torvalds/linux@3d35390
This is an intentional breaking change forcing drivers to acknowledge that the
return type of vm_vault handlers has changed to vm_fault_t and that VM_FAULT_*
must be returned. The driver only needs to be fixed to actually return vm_fault_t,
it already returns VM_FAULT_* values.

torvalds/linux@fcd70cd
Some DRM helper functions were moved to a separate header.

Motivation for this change

Drivers do not build with kernel 5.1.

Things done

Builds without warning/errors and runs without obvious problem on my system with kernel 5.1. Plasma desktop with compositing and some random WebGL samples work fine. I think a few more people should test it.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Produced this on my own based on the errors and kernel changes:

torvalds/linux@3d35390
This is an intentional breaking change forcing drivers to acknowledge that the
return type of vm_vault handlers has changed to vm_fault_t and that VM_FAULT_*
must be returned. The driver only needs to be fixed to actually return vm_fault_t,
it already returns VM_FAULT_* values.

torvalds/linux@fcd70cd
Some DRM helper functions were moved to a separate header.
@ambrop72
Copy link
Contributor Author

Sorry this doesn't actually work with these drivers, I was testing this with 418 drivers. I tried backporting but hit some issue about apparent breakage in linux acpi headers:

/nix/store/kaxpcplyarp30d6c5dxw5k742xzp6rrs-linux-5.1-dev/lib/modules/5.1.0/source/include/acpi/acpi_bus.h:44:25: error: unknown type name 'acpi_handle'; did you mean '__sighandler_t'?

@ambrop72
Copy link
Contributor Author

I managed to fix that but there are more errors, I don't think it is reasonable to keep trying to patch this version.

@ambrop72 ambrop72 closed this May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nividia Drivers with Linux 5.1 are broken
1 participant