Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pyftdi: init at 0.29.4 #61256

Merged
merged 1 commit into from May 15, 2019
Merged

python3Packages.pyftdi: init at 0.29.4 #61256

merged 1 commit into from May 15, 2019

Conversation

astro
Copy link
Contributor

@astro astro commented May 10, 2019

Motivation for this change

Adds a useful Python library.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@astro astro requested a review from FRidh as a code owner May 10, 2019 22:02
marsam
marsam reviewed May 11, 2019
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it requires Python>=35. Can you add the following?

  disabled = pythonOlder "3.5";

besides that, LGTM

@risicle
Copy link
Contributor

risicle commented May 11, 2019

Same results as @marsam for py27 - py37 version works on both non-nixos linux x86_64 and macos 10.13 for me though.

@astro
Copy link
Contributor Author

astro commented May 13, 2019

Thank you. Added that and rebased.

@astro
Copy link
Contributor Author

astro commented May 13, 2019

Sorry to have broken the build with the addition of pythonOlder. That is now fixed.

@marsam
Copy link
Contributor

marsam commented May 15, 2019

@GrahamcOfBorg build python3Packages.pyftdi

@marsam marsam merged commit fa1c611 into NixOS:master May 15, 2019
@marsam
Copy link
Contributor

marsam commented May 15, 2019

Tested locally on NixOS.
Thanks @astro!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@astro @risicle @marsam