Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opensc: use built-in PCSC provider on darwin #60852

Merged
merged 1 commit into from May 10, 2019
Merged

opensc: use built-in PCSC provider on darwin #60852

merged 1 commit into from May 10, 2019

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Make OpenSC usable with hardware tokens on Darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 3, 2019
@thefloweringash thefloweringash changed the title opensc: fix PCSC provider on darwin opensc: use built-in PCSC provider on darwin May 3, 2019
@matthewbauer
Copy link
Member

Since it can work with pcsclite as well, can you make this a flag? Something like withApplePCSC. Default can still be true on darwin.

@thefloweringash
Copy link
Member Author

Tested with pcsclite on macOS. It established a connection to pcscd, but pcscd wasn't able to access my usb card reader. I assume this because macOS has exclusive access (LIBUSB_ERROR_ACCESS).

@c0bw3b
Copy link
Contributor

c0bw3b commented May 4, 2019

@GrahamcOfBorg build opensc

@c0bw3b c0bw3b merged commit 11fe4f3 into NixOS:master May 10, 2019
@thefloweringash thefloweringash deleted the opensc-darwin branch May 10, 2019 16:47
@thefloweringash thefloweringash mentioned this pull request Jul 2, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thefloweringash @matthewbauer @c0bw3b