Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riot-{web,desktop}: 1.0.8 -> 1.1.0 #61275

Merged
merged 2 commits into from May 11, 2019
Merged

riot-{web,desktop}: 1.0.8 -> 1.1.0 #61275

merged 2 commits into from May 11, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented May 11, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link

ghost commented May 11, 2019

Built and tested riot-desktop, it seems to work fine 👍

@BenBals
Copy link
Contributor

BenBals commented May 11, 2019

I might be worth running the checks again as riot-desktop depends on yarn, an update of which has just been merged.

@Ma27
Copy link
Member

Ma27 commented May 11, 2019

Currently testing another PR, but I'm planning to test this after that :)

@BenBals
Copy link
Contributor

BenBals commented May 11, 2019 •
edited

Reviewed points
Possible improvements
Comments

Ran with nix-review

@Ma27
Copy link
Member

Ma27 commented May 11, 2019

Built and tested locally 👍

@Ma27 Ma27 merged commit 88b32c7 into NixOS:master May 11, 2019
@Ma27
Copy link
Member

Ma27 commented May 11, 2019

@nyanloutre thanks!

@nyanloutre nyanloutre deleted the riot_update_1_1_0 branch May 17, 2019 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyanloutre @BenBals @Ma27