Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn: 1.15.2 -> 1.16.0 #61274

Merged
merged 1 commit into from May 11, 2019
Merged

yarn: 1.15.2 -> 1.16.0 #61274

merged 1 commit into from May 11, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 11, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from offlinehacker May 11, 2019 07:42
@Ma27
Copy link
Member

Ma27 commented May 11, 2019

Built and tested locally 👍
As several packages depend on yarn, I'll run a nix-review to search for possible regressions, after that this can be merged :)

@BenBals
Copy link
Contributor

BenBals commented May 11, 2019 •
edited

Reviewed points
Possible improvements
Comments

All test projects I have handy build fine with this. I ran this with nix-review, none of the depending packages fail to build. (The only package depending on the executable I could find is riot-desktop btw.)

@Ma27
Copy link
Member

Ma27 commented May 11, 2019

Ok so in fact the only package that affected by this is riot-desktop according to nix-review. I thought that would be more, sorry 😅

@Ma27 Ma27 merged commit 0015e88 into NixOS:master May 11, 2019
@Ma27
Copy link
Member

Ma27 commented May 11, 2019

@petabyteboy thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ma27 @BenBals