Allow empty backdrop_filter_bounds #16784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 10, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1604330
branch
9 times, most recently
from
1555101
to
44d0129
Compare
Previous to this CL, an empty rect was used to signal that no clipping should be performed on the backdrop filtered image. However, in the corner case that the element with backdrop-filter was zero size, this would cause no clipping to be performed, which is incorrect. With this CL, backdrop_filter_bounds is base::Optional. There is also a test for this case. Change-Id: I8d3d1e383ccf807f1e4f569847bd828a8d04fd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604330 Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: vmpstr <vmpstr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#659603}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1604330
branch
from
44d0129
to
9b76bcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this CL, an empty rect was used to signal that no clipping
should be performed on the backdrop filtered image. However, in the
corner case that the element with backdrop-filter was zero size, this
would cause no clipping to be performed, which is incorrect. With this
CL, backdrop_filter_bounds is base::Optional. There is also a test
for this case.
Change-Id: I8d3d1e383ccf807f1e4f569847bd828a8d04fd3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604330
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659603}