Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alttab: init at 1.4.0 #61228

Merged
merged 2 commits into from May 17, 2019
Merged

alttab: init at 1.4.0 #61228

merged 2 commits into from May 17, 2019

Conversation

sgraf812
Copy link
Contributor

@sgraf812 sgraf812 commented May 10, 2019

Motivation for this change

alttab is a window switcher for X11, designed for minimalistic window
managers or a standalone X11 session.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit should probably be titled "alttab: init at 1.4.0". I can get this to build with the changes I mentioned but can't test it as I do not run X11

pkgs/tools/X11/alttab/default.nix Outdated Show resolved Hide resolved
pkgs/tools/X11/alttab/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved
[`alttab`](https://github.com/sagb/alttab) is a window switcher for X11,
designed for minimalistic window managers or a standalone X11 session.
@sgraf812
Copy link
Contributor Author

Thanks for your review @alexarice! I amended some changes and built it on another machine, so it should just work now.

@worldofpeace worldofpeace changed the title Add https://github.com/sagb/alttab alttab: init at 1.4.0 May 10, 2019
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works fine.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 17, 2019

Let's check build on Darwin and ARMv8:
@GrahamcOfBorg build alttab

@c0bw3b c0bw3b merged commit 508e88f into NixOS:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants