Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.ropper: 1.11.13 → 1.12.1 #61303

Merged
merged 2 commits into from May 11, 2019
Merged

python3Packages.ropper: 1.11.13 → 1.12.1 #61303

merged 2 commits into from May 11, 2019

Conversation

artemist
Copy link
Member

Motivation for this change

ropper is a useful tool to find ROP chains. The previous version was out of date and had a bug which gave incorrect addresses. 1.12.1 is the latest version at the time of this pull requet

Things done

Update hashes and version

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@artemist artemist requested a review from FRidh as a code owner May 11, 2019 15:42
@ofborg ofborg bot requested a review from bennofs May 11, 2019 17:13
@marsam
python3Packages.ropper: update license to bsd3
8ceabe5 
Ropper was relicensed to BSD 3-Clause. See:
sashs/Ropper@b817130
@marsam marsam merged commit 51a083c into NixOS:master May 11, 2019
@marsam
Copy link
Contributor

marsam commented May 11, 2019

Tested locally on NixOS. I took the liberty to update the license, I hope you don't mind
@artemist thanks!

@artemist
Copy link
Member Author

I didn't notice that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@bennofs bennofs Awaiting requested review from bennofs

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@artemist @marsam