Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly detect changes to the navigation frame #2163

Merged
merged 3 commits into from
May 11, 2019

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented May 11, 2019

We had a curious game of ping-pong: Frame 1, the burn editor notices that the reference frame has recently changed, so it returns that information to the flight plan; the flight plan reloads all the data from the C++ side, including the reference frame. Frame 2, the burn editor notices that the reference frame has recently changed, etc.

The fix is to change the burn editor so that it only reports a change if the frame loaded from C++ is actually different from the one it was using.

Fix #2157.

pleroy added 3 commits May 11, 2019 17:21

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@eggrobin eggrobin added the LGTM label May 11, 2019
@pleroy pleroy merged commit e3bed38 into mockingbirdnest:master May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance hit when flight plan window is opened
2 participants